[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#47282] [PATCH v2 13/13] gnu: Add node-lts.
From: |
Jelle Licht |
Subject: |
[bug#47282] [PATCH v2 13/13] gnu: Add node-lts. |
Date: |
Fri, 02 Apr 2021 15:20:24 +0200 |
Efraim Flashner <efraim@flashner.co.il> writes:
> On Tue, Mar 30, 2021 at 01:27:43AM -0400, Timothy Sample wrote:
>> + (arguments
>> + (substitute-keyword-arguments (package-arguments node)
>> + ((#:configure-flags configure-flags)
>> + ''("--shared-cares"
>> + "--shared-libuv"
>> + "--shared-nghttp2"
>> + "--shared-openssl"
>> + "--shared-zlib"
>> + "--shared-brotli"
>> + "--with-intl=system-icu"))
>> + ((#:phases phases)
>> + `(modify-phases ,phases
>> + (replace 'configure
>> + ;; Node's configure script is actually a python script, so we
>> can't
>> + ;; run it with bash.
>> + (lambda* (#:key outputs (configure-flags '()) inputs
>> + #:allow-other-keys)
>> + (let* ((prefix (assoc-ref outputs "out"))
>> + (flags (cons (string-append "--prefix=" prefix)
>> + configure-flags)))
>> + (format #t "build directory: ~s~%" (getcwd))
>> + (format #t "configure flags: ~s~%" flags)
>> + ;; Node's configure script expects the CC environment
>> variable to
>> + ;; be set.
>> + (setenv "CC" (string-append (assoc-ref inputs "gcc")
>> "/bin/gcc"))
>
> again cc-for-target
Ack.
>> [snip]
>> + ;; FIXME: These tests fail on armhf-linux:
>> + ;; https://github.com/nodejs/node/issues/31970
>> + ,@(if (string-prefix? "arm" (%current-system))
>
> This could probably be changed to ,@(when (target-arm32?)
I changed it to ,@(if (target-arm32?), as otherwise the #f-branch
spliced #unspecified into the list.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [bug#47282] [PATCH v2 13/13] gnu: Add node-lts.,
Jelle Licht <=