guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#47852] [PATCH] gnu: Add sc-im


From: ElenQ Technology
Subject: [bug#47852] [PATCH] gnu: Add sc-im
Date: Sat, 17 Apr 2021 22:22:26 +0000

Hey!

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Saturday, April 17, 2021 11:52 PM, jgart <jgart@dismail.de> wrote:

> Hi Guix!
>
> Attached is a patch for sc-im, a terminal based spreadsheet program providing 
> a vim-like experience.
>
> I constructed this package starting from a template provided by Ekaitz that I 
> found below dating from over a year ago:
>
> https://gitlab.com/ekaitz-zarraga/guix-packages/-/blob/master/sc-im.scm
>
> I added Ekaitz as a co-author and added both of our copyrights to the top of 
> the file.
>
> This new version of sc-im is from 16 days ago.
>
> I'm currently getting the following two linter warnings:
>
> the source file name should contain the package name
> permanent redirect from https://github.com/andmarti1424/sc-im.git to 
> https://github.com/andmarti1424/sc-im
>
> Any suggestions for what I need to adjust to make those pass?
>
> best regards,
>
> jgart


I didn't expect this!

My original package was broken, but I left it in my repo so IDK
if taking that as a base was a good idea.
I was trying to package a more complete solution and I left
the package broken... I'm not sure about all the compile flags
you set, you may be missing some interesting plugin support.

I'm taking a look to it.

The first issue related with the name of the package is this:

```
guix/gnu/packages/sc-im.scm:41:14: sc-im@0.8.1: the source file name should 
contain the package name
```

In order to solve this you can use this in the origin desc:

```
        (file-name (git-file-name name version))
```

This is going to clone the repo to an specific filename that
matches Guix's naming style and it's going to remove the
warning.

The second:

```
gnu/packages/sc-im.scm:41:14: sc-im@0.8.1: permanent redirect from 
https://github.com/andmarti1424/sc-im.git to 
https://github.com/andmarti1424/sc-im
```

Just change the url by the other and you're done.

Also I wouldn't add the whole package in an independent file.
It may fit better in other of the categories.

HTH!

Thanks for keeping my name there, but you can clear it with
no issue, this is all your merit, my man.

Best,
Ekaitz





reply via email to

[Prev in Thread] Current Thread [Next in Thread]