bug#47976: [PATCH v2 10/10] gnu: Add orange.

[Leo Famulari]

On Sun, Apr 25, 2021 at 03:26:08AM +0000, Vinicius Monego wrote:
> * gnu/packages/orange.scm (orange): New variable.

Thanks for the v2 patches.

I pushed as 5461efe81f680b577cb12ba7d003e38009628b81 after making the
following changes:

> +             ;; Relax some dependency versions.
> +             (substitute* "requirements-gui.txt" (("PyQtWebEngine>=5.12") 
> ""))

I rewrote this comment to explain the reason for the substitution.

Like I said, we do not change version constraints that are chosen by
upstream developers without a good reason, and so this comment was not
sufficient.

> +       ("python-louvain" ,python-python-louvain)

I missed this in the first round of review but, as specified in our
manual section Python Modules, we don't name packages
"python-python-foo", but instead just "python-foo".

After I changed it, I realized that we already have a python-louvain
package.

Anyways, I changed the pre-existing python-louvain package to be called
python-louvain-0.6, adjusted its user, and renamed your package to
python-louvain.

It would be nice to check if python-scanpy, which uses
python-louvain-0.6, can instead use python-louvain.

Let us know if you want advice about how to handle this situation in the
future.