guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#48028] [PATCH wip-gnome 5/8] gnu: libsoup: Add missing argument and


From: Raghav Gururajan
Subject: [bug#48028] [PATCH wip-gnome 5/8] gnu: libsoup: Add missing argument and input.
Date: Mon, 26 Apr 2021 05:28:34 -0400

Hi Leo!

This looks like it could be its own patch were it not for the fact,
that samba needs to be added as well (what for?)

I have split them into two patches and added comment, in v3.

That doesn't sound very sure to me.  Why are you wrapping binaries
and/or compiling schemas?

It is mainly for compiling schemas, as libsoup doesn't have binaries to wrap. But I just now realized that there is no `[out]/share/glib-2.0/schemas` either. So I removed this in v3.

Careful with the indentation.

Ah, good catch. I have fixed it in v3.

Thanks!

Regards,
RG.

Attachment: OpenPGP_0x5F5816647F8BE551.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]