guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#48226] [PATCH] gnu: pre-commit: Update to 2.12.1.


From: Vinicius Monego
Subject: [bug#48226] [PATCH] gnu: pre-commit: Update to 2.12.1.
Date: Wed, 12 May 2021 06:45:52 +0000

Ludovic Courtès writes:

> Hi,
>
> Vinicius Monego <monego@posteo.net> skribis:
>
>> * gnu/packages/version-control.scm (pre-commit): Update to 2.12.1.
>> [arguments]: Simplify running tests. Make source tree writable and initialize
>> a git repositoryy before check phase.
>> [native-inputs]: Add python-covdefaults, python-coverage, 
>> python-distlib/next,
>> python-pytest-env, which. Use git instead of git-minimal.
>
> What’s the reason to depend on ‘git’ rather than ‘git-minimal’?  (We
> usually avoid that so packages don’t pull more than needed.)

Hi Ludo,

I thought -minimal packages were there for internal use such as solving
bootstrapping issues. Full git is also more common as input in
gnu/packages. Pre-commit builds just fine with git-minimal though.

I sent a v2 without changing git-minimal and fixed the commit message.

>
> Apart from that it LGTM.
>
> Thanks,
> Ludo’.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]