[bug#47979] [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems.

[Leo Famulari]

On Fri, May 21, 2021 at 02:58:48PM +0200, Mathieu Othacehe wrote:
> Those patches are breaking the installer tests because they
> introduce a new dialog. You need to add something like:
> 
> --8<---------------cut here---------------start------------->8---
>     ((checkbox-list (title "Miscellaneous services") (text _)
>                     (items ,services))
>      (filter choose-misc-service? services))
> --8<---------------cut here---------------end--------------->8---
> 
> in the (gnu installer tests) module, to fix this error:

I started implementing this, in the attached v4 patch series.

I tried copying existing code, e.g. the choose-network-service?
part of the tests.

However, it now crashes in a different way when I do `guix environment
guix -- make check-system TESTS=gui-installed-os -j1`:

------
[...]
building /gnu/store/fr1m1ydzpylhm9psk4y9kavk8qb6maq5-Python-3.5.9.tar.xz.drv...
-builder for 
`/gnu/store/fr1m1ydzpylhm9psk4y9kavk8qb6maq5-Python-3.5.9.tar.xz.drv' failed to 
produce output path 
`/gnu/store/f99fblkzb6ip268sg096shhs7wzjyp55-Python-3.5.9.tar.xz'
build of /gnu/store/fr1m1ydzpylhm9psk4y9kavk8qb6maq5-Python-3.5.9.tar.xz.drv 
failed
View build log at 
'/var/log/guix/drvs/fr/1m1ydzpylhm9psk4y9kavk8qb6maq5-Python-3.5.9.tar.xz.drv.bz2'.
cannot build derivation 
`/gnu/store/s7q1xs3mkld23v8541bvrzmq5j5xw5ad-Python-3.5.9.tar.xz.drv': 1 
dependencies couldn't be built 
building /gnu/store/1nnawddi9gw8k71figgphhrpn86dzsxl-activate-service.scm.drv...
cannot build derivation 
`/gnu/store/l2f280iinh1hfp19k49r9vlhnbmbbss8-python-minimal-3.5.9.drv': 1 
dependencies couldn't be built
cannot build derivation 
`/gnu/store/k43m6gi372wzwz0xir1axms8vp2jyv1c-glibc-2.31.drv': 1 dependencies 
couldn't be built
cannot build derivation 
`/gnu/store/20flyxbjjl8as5aca4gzf3b54as1gr9z-ntp-4.2.8p15.drv': 1 dependencies 
couldn't be built 
cannot build derivation 
`/gnu/store/b1py4d1j3ym2k69zbzi0r3hh08afxkn9-shepherd-ntpd.scm.drv': 1 
dependencies couldn't be built 
cannot build derivation 
`/gnu/store/mf7gj4cn0cb9ml3c4v1n1kg1293jjp57-shepherd-ntpd.go.drv': 1 
dependencies couldn't be built
cannot build derivation 
`/gnu/store/gs4kgf2x2syj64zf6s2r02sclffmf48n-shepherd.conf.drv': 1 dependencies 
couldn't be built
cannot build derivation `/gnu/store/dy6w4vsvrxzsq9hg8pj7731k6p0z90cg-boot.drv': 
1 dependencies couldn't be built
building 
/gnu/store/15j31c7b2kc4hf03yxpqjsibgkyi40rv-module-import-compiled.drv...
cannot build derivation 
`/gnu/store/5qkzfk7qmdnvhirsndj5n254y43yqgwz-system.drv': 1 dependencies 
couldn't be built 
guix system: error: build of 
`/gnu/store/5qkzfk7qmdnvhirsndj5n254y43yqgwz-system.drv' failed
conversation expecting pCommand failed with exit code 1.           
                                                                                
                
Press Enter to continue.                                                        
                
attern ((quote installation-complete))                                          
                
May 21 22:47:26 localhost shepherd[1]: Service guix-daemon has been stopped. 
May 21 22:47:26 localhost shepherd[1]: Service guix-daemon has been started. 
May 21 22:47:27 localhost installer[219]: command ("guix" "system" "init" 
"--fallback" "--no-grafts" "--no-substitutes" "/mnt/etc/config.scm" "/mnt") 
failed with exit code 1                   
May 21 22:47:27 localhost installer[183]: unmounting "/mnt/"             
/gnu/store/5fwnbmlfq6bp37n94j36jdcfapm0mhbz-shepherd-marionette.scm:1:1718: 
ERROR:                                                                          
                                    
  1. &pattern-not-matched:                                                      
                
      pattern: ((quote installation-complete))                                  
                
      sexp: (installation-failure)                                              
                
Backtrace:                                                                      
                
           2 (primitive-load "/gnu/store/gpxpcz96pdckj3a69q5cjzxaxq5?")         
              
In ice-9/eval.scm:                                                              
                
   191:35  1 (_ #f)                                                             
                
    619:8  0 (_ #(#<directory (guile-user) 7fffefbabf00> #<variabl?>))

ice-9/eval.scm:619:8: Throw to key `marionette-eval-failure' with args `((quote 
(complete-installation installer-socket)))'.
note: keeping build directory `/tmp/guix-build-installation.drv-8'
builder for `/gnu/store/nphpbnbm3z6xaq8fvl91ihh66n9hhm9m-installation.drv' 
failed with exit code 1
build of /gnu/store/nphpbnbm3z6xaq8fvl91ihh66n9hhm9m-installation.drv failed
View build log at 
'/var/log/guix/drvs/np/hpbnbm3z6xaq8fvl91ihh66n9hhm9m-installation.drv.gz'.
cannot build derivation 
`/gnu/store/50jjjmr51ml9p3qqd5f3kcpbjglmfv4s-gui-installed-os.drv': 1 
dependencies couldn't be built
guix build: error: build of 
`/gnu/store/50jjjmr51ml9p3qqd5f3kcpbjglmfv4s-gui-installed-os.drv' failed
make: *** [Makefile:6859: check-system] Error 1
------

I'm a little lost...

txtI4Zxe2dYzg.txt
Description: Text document

signature.asc
Description: PGP signature