guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#47768] [PATCH v3 00/42] Assorted OCaml patches


From: Julien Lepiller
Subject: [bug#47768] [PATCH v3 00/42] Assorted OCaml patches
Date: Tue, 01 Jun 2021 21:19:42 -0400
User-agent: K-9 Mail for Android

I keep telling myself I should review and merge the changes but I keep having better things to do :p. I'll have a look during the week-end if noone beats me at it :)

Le 1 juin 2021 17:46:36 GMT-04:00, Xinglu Chen <public@yoctocell.xyz> a écrit :
On Tue, Jun 01 2021, pukkamustard wrote:

Hi,

Xinglu Chen <public@yoctocell.xyz> writes:

All the packages build fine, but I haven’t tested anything.

Thanks for the review!

You are welcome!

It follows a V3 with the two changes you suggested (add tests for
ocaml-uunf and merge patches 10 and 11 of V2).

The changes look good to me, and ‘ocaml-uunf’ builds fine.

Erik has tested some of the packages and reports that everything seems
to be fine.

LGTM!

Maybe we are good to merge now?

No objections from me, but I don’t have commit access. :(

Thank you and divoplade for the work!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]