[bug#48729] [PATCH v2 47/47] gnu: Add bitmask-vpn.

[Maxime Devos]

One comment about this patch.

Raghav Gururajan via Guix-patches via schreef op do 03-06-2021 om 16:51 [-0400]:
> 
> +         (replace 'build
> +           (lambda* (#:key source system outputs search-paths build-flags 
> unpack-path inputs #:allow-other-keys)
> +             (for-each
> +              (lambda (directory)
> +                ((assoc-ref %standard-phases 'build)
> +                 #:source source
> +                 #:system system
> +                 #:outputs outputs
> +                 #:search-paths search-paths
> +                 #:build-flags build-flags
> +                 #:unpack-path unpack-path
> +                 #:inputs inputs
> +                 #:import-path directory))
> +              (list [...]

This can be done a bit simpler, and less prone to breakage
if/when a new keyword argument is introduced at some poit
in the future (untested):

(replace 'build
  (lambda arguments
    (lambda (directory)
      (apply (assoc-ref %standard-phases 'build)
             `(,@arguments #:directory ,directory)))))

WDYT? Likewise in other places.

Also, trailing #t in phases aren't required anymore
(but harmless), though you probably know that already.
(The warning should disappear when core-updates is merged.)

Greetings,
Maxime.

signature.asc
Description: This is a digitally signed message part