[bug#48893] [PATCH] New package: ack

[Ludovic Courtès]

Hi,

Ryan Sundberg <ryan@arctype.co> skribis:

> From fea54a57b5b4e1cdc6bd642ae499fbaafad5cb62 Mon Sep 17 00:00:00 2001
> From: Ryan Sundberg <ryan@arctype.co>
> Date: Sun, 31 Jan 2021 10:29:47 -0800
> Subject: [PATCH] gnu: Add ack version 3.5.0
>
> * gnu/packages/search.scm (ack): New variable.
>
> Signed-off-by: Ryan Sundberg <ryan@arctype.co>

Overall this LGTM.  However…

> +(define-public ack
> +  (package
> +    (name "ack")
> +    (version "3.5.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "https://beyondgrep.com/ack-v"; version))
> +        (sha256 (base32 
> "17wq9c1pwisbg4mcmvmdaym8hlawx209iriaxjlw9hwi0v4x6w38"))))
> +    (inputs `(("perl" ,perl)))
> +    (build-system copy-build-system)

… I noticed this:

--8<---------------cut here---------------start------------->8---
$ head -4 $(./pre-inst-env guix build ack)/bin/ack
#!/gnu/store/8zvc5mvk0xm3ygrxsgpyy5ilxb5rzjry-perl-5.30.2/bin/perl
#
# This file, ack, is generated code.
# Please DO NOT EDIT or send patches for it.
--8<---------------cut here---------------end--------------->8---

Could you arrange so that the ‘ack’ file is “built from source”?
We usually try hard to build everything from source.

Thanks in advance,
Ludo’.