[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#48933] [PATCH] build: Make outputs of node-build-system reproducibl
From: |
Lars-Dominik Braun |
Subject: |
[bug#48933] [PATCH] build: Make outputs of node-build-system reproducible. |
Date: |
Thu, 17 Jun 2021 14:12:18 +0200 |
Hi Ludo,
> > (define* (repack #:key inputs #:allow-other-keys)
> > - (invoke "tar" "-czf" "../package.tgz" ".")
> > + (invoke "tar"
> > + ;; Add options suggested by
> > https://reproducible-builds.org/docs/archives/
*
> > + "--sort=name"
> > + (string-append "--mtime=" (getenv "SOURCE_DATE_EPOCH"))
>
> I think it should be "--mtime=@".
you’re right, fixed.
> I didn’t know about this ‘--pax-option’ trick; since it’s only useful
> when POSIXLY_CORRECT is set, perhaps we can remove it?
True, removed.
> (guix docker) does this:
> and (guix packages) does something similar.
Hm, maybe it would make sense to export a set of options, so
build systems/packages can share them? Or create a package that wraps
tar with the proper options?
> So ‘--sort=name’ seems to be missing.
It’s present, see above ↑*
Updated patch attached. I’ll push it if there are no further comments.
Cheers,
Lars
0001-build-Make-outputs-of-node-build-system-reproducible.patch
Description: Text Data