[bug#49101] [PATCH v2 1/5] gnu: ocaml4.07-pcre: Switch to default OCaml compiler.

[Xinglu Chen]

On Sat, Jun 19 2021, Julien Lepiller wrote:

>> -(define-public ocaml4.07-pcre
>> +(define-public ocaml-pcre
>>    (package
>> -    (name "ocaml4.07-pcre")
>> -    (version "7.4.1")
>> -    (source (origin
>> -              (method git-fetch)
>> -              (uri (git-reference
>> -                     (url "https://github.com/mmottl/pcre-ocaml";)
>> -                     (commit version)))
>> -              (file-name (git-file-name name version))
>> -              (sha256
>> -               (base32
>> -
>> "11sd8g668h48790lamz0riw9jgnfkaif5qdfa0akcndwa6aj07jf"))))
>> +    (name "ocaml-pcre")
>> +    (version "7.4.6")
>
> If possible, it would be best not to update pcre at the same time. You
> can try updating first, then switch to the latest ocaml, or the other
> way around. If it's really not possible, please add the version number
> to the commit message.

OK, will keep this in mind.

>> +    (source
>> +      (origin
>> +        (method git-fetch)
>> +        (uri (git-reference
>> +              (url "https://github.com/mmottl/pcre-ocaml";)
>> +              (commit version)))
>> +        (file-name (git-file-name name version))
>> +        (sha256
>> +          (base32
>> +
>> "11mck879p5zvkghps4ky8yslm0isgz52d84adl0dmcfxv2ibvcym"))))
>> (build-system dune-build-system) (arguments
>> -     `(#:test-target "."
>> -       #:ocaml ,ocaml-4.07
>> -       #:findlib ,ocaml4.07-findlib
>> -       #:dune ,ocaml4.07-dune))
>> +     ;; No tests.
>> +     '(#:tests? #f))
>
> Are you sure there are no tests? There used to be tests that could be
> found at the top-level directory (#:test-target "."). Doesn't that work
> anymore?

Looking at the Git repo[1], I don’t see any files that would indicate
that there are tests.  Maybe I missed something, but I will see if
(#:test-target ".") does anything useful.

[1]: https://github.com/mmottl/pcre-ocaml

signature.asc
Description: PGP signature