[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#49196] [PATCH] import: utils: 'recursive-import' skips unfound pack
From: |
zimoun |
Subject: |
[bug#49196] [PATCH] import: utils: 'recursive-import' skips unfound packages |
Date: |
Fri, 25 Jun 2021 08:53:37 +0200 |
Hi,
On Fri, 25 Jun 2021 at 06:22, Sarah Morgensen <iskarian@mgsn.dev> wrote:
> The goal of this patch is just to allow recursive import to provide a
> usable result despite some failures, when the importer supports it. I'd
> rather hunt down one package than 20+ :) This may make reporting errors
> more difficult, but I think the use-case is worth it.
I agree.
> Good catch. I did not think to handle the toplevel package not being
> found! This actually leads to making this a much simpler patch...
>
> --8<---------------cut here---------------start------------->8---
> - (map node-package
> + (filter-map node-package
> (topological-sort (list (lookup-node package-name version))
> --8<---------------cut here---------------end--------------->8---
Cool!
> Yes, this is very much just a stopgap. In your words (from #45984):
>
> > Well, this patch set are trivial changes that quickly fix the current
> > broken situation without a deep revamp.
I agree. Heh! I am consistent with my words. ;-)
> I will follow up with an updated patch.
Cool, thanks!
Cheers,
simon
[bug#49196] [PATCH v4 1/3] import: go: Return false for package not found., zimoun, 2021/06/28