[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#49238] [PATCH v3 2/2] gnu: Add ytfzf.
From: |
Maxime Devos |
Subject: |
[bug#49238] [PATCH v3 2/2] gnu: Add ytfzf. |
Date: |
Mon, 05 Jul 2021 14:02:20 +0200 |
User-agent: |
Evolution 3.34.2 |
Hi,
> + (modify-phases %standard-phases
> + (add-after 'unpack 'patch
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (binutils (assoc-ref inputs "binutils"))
The 'binutils' input doesn't seem to be used anywhere.
> + if [ -n "$sub_list" ]; then
> +- [ -n "$selected_sub" ] || selected_sub=$(printf "$sub_list" |
> eval "$menu_command") && youtube-dl --sub-lang $selected_sub
> --write-auto-sub --skip-download "$selected_urls" -o /tmp/ytfzf &&
> YTFZF_SUBT_NAME="--sub-file=/tmp/ytfzf.$selected_sub.vtt" || printf "Auto
> generated subs not available."
> ++ [ -n "$selected_sub" ] || selected_sub=$(printf "$sub_list" |
> eval "$menu_command") && @youtube-dl@ --sub-lang $selected_sub
> --write-auto-sub --skip-download "$selected_urls" -o /tmp/ytfzf &&
> YTFZF_SUBT_NAME="--sub-file=/tmp/ytfzf.$selected_sub.vtt" || printf "Auto
> generated subs not available."
For a previous version of this patch series,
I noted that writing /tmp/ytfzf is quite possibly
insecure, and also incorrect on multi-user systems.
I don't see this addressed anywhere.
Greetings,
Maxime.
signature.asc
Description: This is a digitally signed message part