[bug#49531] Removing input labels for Rust #:cargo-inputs & co.?

[Ludovic Courtès]

Sarah Morgensen <iskarian@mgsn.dev> skribis:

> Sanitize cargo's inputs here since the package field sanitizers don't
> know about them.
>
> * guix/packages.scm (sanitize-inputs): Export procedure.
> * guix/build-system/cargo.scm (package-cargo-inputs)
> (package-cargo-development-inputs)
> (lower): Sanitize inputs before using them.

So, do we want to do that?  :-)

I’d say yes, but what do Rust folks think?  (Efraim?)

Are labels of #:cargo-inputs & co. used at all?  If not, we can probably
go one step further and have sanitation remove input labels instead of
adding them.

And then, how do we handle the transition?  I’m not enthusiastic about
customizing ‘guix style’ for Rust packages; should we embark on manual
changes of the 2.4K Rust packages?

> +++ b/guix/packages.scm
> @@ -7,6 +7,7 @@
>  ;;; Copyright © 2019 Marius Bakke <mbakke@fastmail.com>
>  ;;; Copyright © 2020, 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
>  ;;; Copyright © 2021 Chris Marusich <cmmarusich@gmail.com>
> +;;; Copyright © 2021 Sarah Morgensen <iskarian@mgsn.dev>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -117,6 +118,7 @@
>              prepend                               ;syntactic keyword
>              replace                               ;syntactic keyword
>              modify-inputs
> +            sanitize-inputs

I’d rather not export it to make sure users don’t mistakenly view it as
part of the public interface; it’s really just an internal helper.

Thanks,
Ludo’.