[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#49736] [PATCH] gnu: Add emacs-nasm-mode.
From: |
Nicolas Goaziou |
Subject: |
[bug#49736] [PATCH] gnu: Add emacs-nasm-mode. |
Date: |
Tue, 27 Jul 2021 19:43:30 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hello,
Ron Nazarov via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/emacs-xyz.scm (emacs-nasm-mode): New variable.
Thank you.
> +(define-public emacs-nasm-mode
> + (package
> + (name "emacs-nasm-mode")
> + (version "20190410.342")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://melpa.org/packages/nasm-mode-"
> + version
> + ".el"))
Please use Github repository instead of MELPA. The latter has a strange
versioning scheme, and source is not stable.
> + (sha256
> + (base32
> + "10js4bdgqgvlhpk3mgq3rjglmkgkxchj1bny16bkl7glw5mqwl8c"))))
> + (build-system emacs-build-system)
> + (home-page "https://github.com/skeeto/nasm-mode")
> + (synopsis "NASM x86 assembly major mode")
> + (description
> + "@code{nasm-mode} is a major mode for editing NASM x86 assembly
> programs.
I would write NASM mode is ...
> +It includes syntax highlighting, automatic indentation, and imenu
> integration.
> +Unlike Emacs' generic @code{asm-mode}, it understands NASM-specific syntax.")
ditto: ASM mode.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou