[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#49946] [PATCH 08/31] gnu: node: Patch /usr/bin/env in node-gyp.
From: |
Pierre Langlois |
Subject: |
[bug#49946] [PATCH 08/31] gnu: node: Patch /usr/bin/env in node-gyp. |
Date: |
Wed, 11 Aug 2021 16:36:11 +0100 |
User-agent: |
mu4e 1.6.2; emacs 27.2 |
Hi Maxime,
Maxime Devos <maximedevos@telenet.be> writes:
> [[PGP Signed Part:Undecided]]
> Pierre Langlois schreef op ma 09-08-2021 om 00:33 [+0100]:
>> @@ -120,6 +120,10 @@
>> (("'/usr/bin/env'")
>> (string-append "'" (which "env") "'")))
>>
>> + ;; Fix /usr/bin/env shebang in node-gyp.
>> + (substitute* "deps/npm/node_modules/node-gyp/bin/node-gyp.js"
>> + (("#!/usr/bin/env") (string-append "#!" (which "env"))))
>
> For cross-compilation, this should most likely be
> (string-append (assoc-ref inputs "coreutils") "/bin/env")
> or something like that instead. Likewise in other places.
> The old code uses (which "env") in some cases, but those
> are probably wrong (except where it is patched in tests).
Good point, I didn't consider cross-compilation. Actually, trying it,
it looks like our node package doesn't currently cross-compile
correctly. I just managed to get it to cross-compile though, I'll
submit another patch for it! In the meantime, with this series I agree
it's better for the new code to be correct from the begining though.
Thanks for taking a look!
Pierre
signature.asc
Description: PGP signature
- [bug#49946] [PATCH 00/31] Tree-sitter, node-gyp addon support and emacs-tree-sitter, Pierre Langlois, 2021/08/08
- [bug#49946] [PATCH 01/31] gnu: rust-chunked-transfer: Update to 1.4.0., Pierre Langlois, 2021/08/08
- [bug#49946] [PATCH 03/31] gnu: Add rust-html-escape., Pierre Langlois, 2021/08/08
- [bug#49946] [PATCH 06/31] gnu: rust-spin: Update to 0.7., Pierre Langlois, 2021/08/08
- [bug#49946] [PATCH 07/31] gnu: Add tree-sitter., Pierre Langlois, 2021/08/08
- [bug#49946] [PATCH 07/31] gnu: Add tree-sitter., Pierre Langlois, 2021/08/13
- [bug#49946] [PATCH v2 00/33] gnu: Add tree-sitter., Pierre Langlois, 2021/08/29
- [bug#49946] [PATCH v2 01/33] gnu: rust-chunked-transfer: Update to 1.4.0., Pierre Langlois, 2021/08/29
- [bug#49946] [PATCH v2 13/33] gnu: Add tree-sitter-cpp., Pierre Langlois, 2021/08/29
- [bug#49946] [PATCH v2 04/33] gnu: Add rust-smallbitvec., Pierre Langlois, 2021/08/29
- [bug#49946] [PATCH v2 18/33] gnu: Add tree-sitter-java., Pierre Langlois, 2021/08/29
- [bug#49946] [PATCH v2 20/33] gnu: Add tree-sitter-json., Pierre Langlois, 2021/08/29