[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#50201] [PATCH core-updates-frozen 0/52] Support cross-compilation i
From: |
Maxime Devos |
Subject: |
[bug#50201] [PATCH core-updates-frozen 0/52] Support cross-compilation in glib-or-gtk-build-system and fix cross-compilation errors |
Date: |
Mon, 30 Aug 2021 14:16:34 +0200 |
User-agent: |
Evolution 3.34.2 |
Mathieu Othacehe schreef op za 28-08-2021 om 15:33 [+0200]:
> Hello Maxime,
>
> > It should not cause any rebuilds. You can test with
> > ./pre-inst-env guix build gtk+ --target=aarch64-linux-gnu.
> > There is still some work to be done though:
>
> Thanks for this series, that a great step forward. I will have a closer
> look later, but as a general remark, should we really target the
> core-updates-frozen branch?
>
> Maybe it would make more sense to target the core-updates branch as
> there's still some work required to get gtk+ to cross-build.
Going by the patch series title: ‘Support cross-compilation in
glib-or-gtk-build-system’, I don't see why this would have to go in
core-updates instead of core-updates-frozen, because:
(1) no rebuilds, unless I missed something (*)
(2) due to (1), it doesn't introduce bugs
(3) after this patch series, glib-or-gtk-build-system _does_ support
support cross-compilation
(*) In one patch, I unconditionally added a glib:bin input. IIRC, it failed
to build natively previously, but I'd better check again ..
For example, cairo, which uses glib-or-gtk-build-system, now cross-compiles
for aarch64-linux-gnu. True, ideally gtk+ would cross-compile as well,
but cairo being cross-compilable is already useful (e.g., it's a
dependency of harfbuzz which is a dependency of qtbase which is a dependency
of graphical Qt software.) (**)
(**) qtbase (indirectly) depends on perl-file-mimeinfo and 'perl-build-system'
doesn't support cross-compilation, so this argument is probably not really
convincing ... Maybe texlive-bin would be a
better example?(***)
(***) The dependency libungif fails to cross-compile/
Also, hacking on master (or core-updates-frozen) is simpler on than on
core-updates,
due to more substitutes, and it is more appealing to me because the
cross-compilation
support would be available earlier to most people than if it the patches were
based
on core-updates.
As a general principle, I prefer basing patches on 'master'. That wasn't
possible
here due to the use of G-exps in glib-or-gtk-build-system, so I based the
patches
on 'core-updates-frozen' instead. That goes a bit against
(guix)Submitting Patches though, so I would understand if the patches will have
to
be rebased on core-updates:
When we decide to start building the ‘staging’ or ‘core-updates’
branches, they will be forked and renamed with the suffix
‘-frozen’, at which time only bug fixes may be pushed to the frozen
branches.
unless ‘let glib-or-gtk-build-system support cross-compilation’ counts as a bug
fix.
To me, this is not all that different from other cross-compilation fixes like
"CC=gcc" --> (string-append "CC=" (cc-for-target)) or moving inputs between
'native-inputs' and 'inputs', but YMMV.
Greetings,
Maxime.
signature.asc
Description: This is a digitally signed message part
- [bug#50201] [PATCH 51/52] gnu: pango: Add bash-minimal input when cross-compiling., (continued)
- [bug#50201] [PATCH 51/52] gnu: pango: Add bash-minimal input when cross-compiling., Maxime Devos, 2021/08/25
- [bug#50201] [PATCH 37/52] gnu: at-spi2-core: Don't cross-compile documentation., Maxime Devos, 2021/08/25
- [bug#50201] [PATCH 35/52] gnu: avahi: Find 'TARGET-pkg-config' when cross-compiling., Maxime Devos, 2021/08/25
- [bug#50201] [PATCH 32/52] gnu: json-glib: Don't build introspection data when cross-compiling., Maxime Devos, 2021/08/25
- [bug#50201] [PATCH 36/52] gnu: avahi: Use the cross-compiled bash., Maxime Devos, 2021/08/25
- [bug#50201] [PATCH 49/52] gnu: gdk-pixbuf: Find docbook when cross-compiling., Maxime Devos, 2021/08/25
- [bug#50201] [PATCH 45/52] gnu: Add pkg-config-for-build., Maxime Devos, 2021/08/25
- [bug#50201] [PATCH 34/52] gnu: libdaemon: Support cross-compilation to aarch64-linux-gnu., Maxime Devos, 2021/08/25
- [bug#50201] [PATCH core-updates-frozen 0/52] Support cross-compilation in glib-or-gtk-build-system and fix cross-compilation errors, Mathieu Othacehe, 2021/08/28
- [bug#50201] [PATCH core-updates-frozen 0/52] Support cross-compilation in glib-or-gtk-build-system and fix cross-compilation errors,
Maxime Devos <=
- [bug#50201] [PATCH core-updates-frozen 0/52] Support cross-compilation in glib-or-gtk-build-system and fix cross-compilation errors, Maxime Devos, 2021/08/30