[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#50750] [PATCH 1/2] gnu: Add trezor-gpg-pinentry-tk 0.0.10.
From: |
Xinglu Chen |
Subject: |
[bug#50750] [PATCH 1/2] gnu: Add trezor-gpg-pinentry-tk 0.0.10. |
Date: |
Fri, 24 Sep 2021 15:49:25 +0200 |
On Thu, Sep 23 2021, Attila Lendvai wrote:
> * gnu/packages/finance.scm (trezor-gpg-pinentry-tk): New variable.
> ---
> gnu/packages/finance.scm | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
> index 4aaab58906..9b073541de 100644
> --- a/gnu/packages/finance.scm
> +++ b/gnu/packages/finance.scm
> @@ -884,6 +884,31 @@ the Monero GUI client.")
> Ledger Nano as a hardware SSH/GPG agent.")
> (license license:lgpl3)))
>
> +(define-public trezor-gpg-pinentry-tk
> + (package
> + (name "trezor-gpg-pinentry-tk")
> + (version "0.0.10")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/rendaw/trezor-gpg-pinentry-tk/")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "1mblx4favmw4nf7k9rfl00ivv77kgdiwghyz4xv5cp0v410kjaqc"))))
> + (build-system python-build-system)
> + (propagated-inputs
> + `(("python-tkinter" ,python "tk")))
> + (home-page "https://github.com/rendaw/trezor-gpg-pinentry-tk")
> + (synopsis "A GPG PIN entry program for use with trezor-agent
> +or for people with number-only PINs.")
The synopsis starts with an article, and it is a bit long (see “16.4.4
Synopses and Descriptions” in the manual for more details), I suggest
GPG pinentry program for use with @code{trezor-agent}
> + (description
> + "An alternate PIN entry for use with trezor-agent, or for people
> +with number-only PINs. It displays a grid of unlabeled buttons and
> +supports configurable keyboard mappings.")
The first sentence lacks a subject, and there should be two spaces after
a period. I suggest
This package provides a GPG pinentry program for use with
@code{trezor-agent}, or for people with number-only PINs. It displays
a grid of unlabeled buttons and supports configurable keyboard
settings.
> + (license license:lgpl3)))
The ‘license.txt’ file says BSD-2.
Could you send an updated patch?
signature.asc
Description: PGP signature