guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#50967] [PATCH 00/12] Move (gnu home-services XYZ) to (gnu services


From: Ludovic Courtès
Subject: [bug#50967] [PATCH 00/12] Move (gnu home-services XYZ) to (gnu services XYZ)
Date: Mon, 04 Oct 2021 16:01:28 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> * gnu/home-services.scm
> (%service-type-path): Search home services in "gnu/services".
> * gnu/home-services.scm: Update documentation string.
> ---
>  gnu/home-services.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/home-services.scm b/gnu/home-services.scm
> index 9f1e986616..a244a15511 100644
> --- a/gnu/home-services.scm
> +++ b/gnu/home-services.scm
> @@ -512,10 +512,10 @@ environment, and its configuration file, when 
> available.")))
>  
>  (define %service-type-path
>    ;; Search path for service types.
> -  (make-parameter `((,%guix-home-root-directory . "gnu/home-services"))))
> +  (make-parameter `((,%guix-home-root-directory . "gnu/home/services"))))
>  

I think it would make more sense to squeeze patches 2 to 12 (inclusive)
as a single patch.  That way, both the previous and the next commit
would be in working state, which may not be the case when we rename
things one by one (for example, renamed service modules won’t be
discovered until the hunk above is applied.)

Otherwise LGTM, thanks!

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]