[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#42180] bug#51061: [PATCH v2 01/23] guix: Add extracting-download.
From: |
Ludovic Courtès |
Subject: |
[bug#42180] bug#51061: [PATCH v2 01/23] guix: Add extracting-download. |
Date: |
Sat, 09 Oct 2021 15:16:06 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi Hartmut,
Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:
>> That’s really not how we work, nor how we should work IMO. There were
>> ~24h between the time you sent this series and the time you pushed it,
>> only quick comments on 2 patches out of 23, and zero “LGTMs”.
>
> I apologize for pushing the patch series that fast. I can't tell what
> exactly did make be rush on this - maybe I just wanted to get this
> from my table. Not good, anyhow.
OK. For the record, the process is documented here:
https://guix.gnu.org/manual/devel/en/html_node/Commit-Access.html
If you think something needs to be clarified, please let us know.
> Fine for me. (I'd appreciate if someone else would do this, as I'm not
> sure about a meaningful commit message. An I'll be offline during the
> day today.)
I see Tobias reverted them (thanks!).
> I'll then provide a new set of three patches - split by topic: 1)
> extracting downloader, 2) hexpm-importer, 3) rebar-build-system and
> required packages.
Yes. Please, do take into account the partial review I’ve already done.
In particular, be sure to follow our standards in terms of testing and
documentation (it’s fine to delay documentation for a v2/v3 of the patch
series until we’ve agreed on the interfaces; the commits that will be
pushed will have to include code, documentation, and tests.)
Thanks for your message,
Ludo’.
- [bug#42180] bug#51061: [PATCH v2 01/23] guix: Add extracting-download., (continued)
- [bug#42180] [PATCH v2 03/23] guix: Add rebar3 build-system., Hartmut Goebel, 2021/10/06
- [bug#42180] [bug#51061] [PATCH v2 03/23] guix: Add rebar3 build-system., Maxime Devos, 2021/10/06
- [bug#42180] [bug#51061] [PATCH v2 03/23] guix: Add rebar3 build-system., Hartmut Goebel, 2021/10/06
- [bug#42180] [bug#51061] [PATCH v2 03/23] guix: Add rebar3 build-system., Maxime Devos, 2021/10/06
- [bug#42180] [bug#51061] [PATCH v2 03/23] guix: Add rebar3 build-system., Hartmut Goebel, 2021/10/06
- [bug#51061] [PATCH v2 03/23] guix: Add rebar3 build-system., Maxime Devos, 2021/10/06
- [bug#42180] [bug#51061] [PATCH v2 03/23] guix: Add rebar3 build-system., Hartmut Goebel, 2021/10/07
- [bug#51061] [PATCH v2 01/23] guix: Add extracting-download., Ludovic Courtès, 2021/10/07
- [bug#42180] bug#51061: [PATCH v2 01/23] guix: Add extracting-download., Hartmut Goebel, 2021/10/08
- [bug#42180] bug#51061: [PATCH v2 01/23] guix: Add extracting-download.,
Ludovic Courtès <=
- [bug#42180] bug#51061: [PATCH v2 01/23] guix: Add extracting-download., Hartmut Goebel, 2021/10/08
[bug#42180] bug#51061: [PATCH v2 01/23] guix: Add extracting-download., Ludovic Courtès, 2021/10/07
[bug#42180] [PATCH v2 04/23] gnu: Add erlang-cf., Hartmut Goebel, 2021/10/06
[bug#42180] [PATCH v2 08/23] gnu: Add erlang-bbmustache., Hartmut Goebel, 2021/10/06
[bug#42180] [PATCH v2 05/23] gnu: Add erlang-certifi., Hartmut Goebel, 2021/10/06
[bug#42180] [PATCH v2 09/23] gnu: Add erlang-getopt., Hartmut Goebel, 2021/10/06
[bug#42180] [PATCH v2 06/23] gnu: Add erlang-erlware-commons., Hartmut Goebel, 2021/10/06
[bug#42180] [PATCH v2 07/23] gnu: Add erlang-cth-readable., Hartmut Goebel, 2021/10/06
[bug#51061] [PATCH v2 12/23] gnu: Add erlang-parse-trans., Hartmut Goebel, 2021/10/06
[bug#51061] [PATCH v2 15/23] gnu: Add erlang-relx., Hartmut Goebel, 2021/10/06