guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#51948] [PATCH] Meson needs proper wrapping


From: Vivien Kraus
Subject: [bug#51948] [PATCH] Meson needs proper wrapping
Date: Fri, 19 Nov 2021 14:20:50 +0100
User-agent: mu4e 1.6.10; emacs 27.2

Ludovic Courtès <ludo@gnu.org> writes:
> Vivien Kraus <vivien@planete-kraus.eu> skribis:
>> Meson needs to be wrapped, but the wrapping must not execute a new
>> process, if I understand correctly. I could use wrap-script, but I think
>> it’s more pythonic to set the path through sys.path rather than setting
>> an environment variable.
>
> Isn’t that what ‘wrap-script’ does?
I think wrap-script converts the python script to a guile script that
happens to be the same file as the python script. I realize it won’t
even insert python code in the final program, so the wrapping code won’t
be executed when the python module is loaded by the python interpreter.

> How about providing a user-facing ‘meson’ package that incorporates this
> fix, while keeping the other ‘meson’ packages unchanged, to avoid
> rebuilding too much?  This can be achieved by marking the other packages
> as hidden.
I pushed an update that does precisely that. Is the name "meson-wrapped"
OK? Also, how can I influence guix to rather install the wrapped version
when the user invokes "guix install meson"?

> Could you check ‘guix gc --references meson’ to make sure it does not
> capture too much?  (GUIX_PYTHONPATH might contain references to
> build-time dependencies.)

I see, the only thing to wrap is just the "out" output in fact.

Attachment: 0001-gnu-meson-Extend-the-python-path-in-the-installed-pr.patch
Description: Text Data

Vivien

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]