guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#51853] [PATCH v2 2/2] gnu: sendgmail: Don't limit domain name of se


From: Liliana Marie Prikler
Subject: [bug#51853] [PATCH v2 2/2] gnu: sendgmail: Don't limit domain name of sender.
Date: Sat, 20 Nov 2021 07:54:06 +0100
User-agent: Evolution 3.34.2

Hi,

Am Samstag, den 20.11.2021, 00:43 -0500 schrieb Philip McGrath:
>  (define-public sendgmail
>    (let ((commit "e3229155a4037267ce40f1a3a681f53221aa4d8d")
> -        (revision "0"))
> +        (revision "1"))
IIRC you only need to bump revision when commit changes.  When the
recipe itself changes, e.g. due to an added patch, I'm pretty sure the
package would be rebuilt either way.  Can you check whether you really
need to bump it?

>      (package
>        (name "sendgmail")
>        (version (git-version "0.0.0" revision commit))
> @@ -4657,6 +4657,9 @@ (define-public sendgmail
>                 (url "https://github.com/google/gmail-oauth2-tools";)
>                 (commit commit)))
>           (file-name (git-file-name name version))
> +         (patches (search-patches
> +                   "sendgmail-remove-domain-restriction.patch"
> +                   "sendgmail-accept-ignored-gsuite-flag.patch"))
>           (sha256
>            (base32
>             "1cxpkiaajhq1gjsg47r2b5xgck0r63pvkyrkm7af8c8dw7fyn64f")))
> )
> @@ -4676,5 +4679,9 @@ (define-public sendgmail
>         "The @command{sendgmail} command provides a minimal sendmail-
> compatible
>  front-end that connects to Gmail using OAuth2.  It is specifically
> designed
>  for use with @code{git send-email}.  The command needs a Gmail API
> key to
> -function.")
> +function.
> +
> +Guix's version of @command{sendgmail} has been patched for
> compatibility with
> +all known forks, including support for non-@code{@@gmail.com} email
> +addresses.")
Funnily enough non-@code is highlighted as a mail address for me.  It's
not high priority, but you might want to rewrite that sentence to
convey the same information in a way that @code is not preceded by
anything.

Cheers






reply via email to

[Prev in Thread] Current Thread [Next in Thread]