[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#53046] [PATCH] gnu: python-args: Patch reference to basestring.
From: |
Tanguy LE CARROUR |
Subject: |
[bug#53046] [PATCH] gnu: python-args: Patch reference to basestring. |
Date: |
Mon, 10 Jan 2022 08:48:49 +0100 |
User-agent: |
alot/0.10 |
Hi Maxime,
Quoting Maxime Devos (2022-01-09 22:34:52)
> Maxime Devos schreef op zo 09-01-2022 om 22:15 [+0100]:
> > > This fixes a build failure in the 'sanity-check' phase.
> > > + (substitute* "args.py"
> > > + (("basestring") "str"))
> >
> > Does it actually fix the build failure, or is it only suppressed?
> > [...]
>
> According to <https://github.com/kennethreitz-archive/args/pull/19>,
> the tests are excluded from the tarball. It would be useful to
> switch to git-fetch such that tests can be run, verifying whether
> this change causes problems or not.
I'll switch to `git-fetch` and see! Maybe Python 2 tests will also pass
with the patch!?
I'll apply all your suggestions and send a v2.
Thanks again for your time and advice.
--
Tanguy