[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#48735] [PATCH] gnu: Add clojure-tools.
From: |
Ricardo Wurmus |
Subject: |
[bug#48735] [PATCH] gnu: Add clojure-tools. |
Date: |
Wed, 12 Jan 2022 09:45:02 +0100 |
User-agent: |
mu4e 1.6.10; emacs 27.2 |
Hi Reily,
this new patch set looks good. Thank you very much!
I just have a few minor comments/questions:
- build phases and snippets no longer need to end on #t or #true
- nitpick: I’m not a fan of the somewhat unusual location of the
“home-page” field, but I understand that you’re reusing the URL. My
personal preference is not to do that and to move the “home-page”
field above the “synopsis” field.
- some packages have disabled tests; it would be good to add a comment
as to why the tests are disabled
- some descriptions are not complete sentences.
If you can tell me about these disabled tests (e.g. in
clojure-tools-deps-alpha), I can add comments and make the changes I
suggested above when applying the patches. (You don’t need to send new
patches.)
Thanks again!
--
Ricardo
- [bug#48735] [PATCH] gnu: Add clojure-tools.,
Ricardo Wurmus <=