[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#48463] gnu: Add j.
From: |
Liliana Marie Prikler |
Subject: |
[bug#48463] gnu: Add j. |
Date: |
Thu, 13 Jan 2022 18:51:14 +0100 |
User-agent: |
Evolution 3.42.1 |
Hi,
Am Donnerstag, dem 13.01.2022 um 16:51 +0900 schrieb
elaexuotee@wilsonb.com:
> >
> > > +(define* (make-j #:key
> > > + (builder "guix.gnu.org")
> > > + vername
> > > + revision
> > > + hash
> > > + (type 'release)
> > > + commit
> > > + (patches '())
> > > + (extra-inputs '())
> > > + (extra-envars '()))
> > > + (package
> > > + (name (jname "jsoftware-j" type))
> > > + (version (jversion->string vername revision))
> > > + (source
> > > + (origin
> > > + (method git-fetch)
> > > + (uri (git-reference
> > > + (url "https://github.com/jsoftware/jsource")
> > > + (commit (or commit (jinfo->git-tag vername type
> > > revision))))
> > Vername sounds a little weird, make that version-base or something
> > clearer. Also, the argument #:commit is used in an unclear fashion
> > --
> > if you were to pass an actual commit hash to it, it'd still be
> > treated
> > as a release and not be using git-version.
>
> Cool. I had a similar sense, but our ideas are a lot sharper than the
> ones I had. This actually prompted me to do some code cleanup,
> leveraging now-me who has a bit more Guile experience than past-me.
> At the very least, variable names should be more descriptive and
> consistent, overall.
Note, that the current version still ignores commit. I've attached a
proof of concept patch, which fixes that, plus some other minor things,
but it now uses a pair for version. Also it's untested, so treat with
care.
> Good idea. Upstream's build scripts condition a *lot* of behaviour on
> the j64avx environment variable, so it might not be straightforward,
> but I will put this on the to-do list of future improvements.
>
> (Note, the code block quoted here got much simplified in the current
> patch.)
Reading /proc/cpuinfo is not nice. Please use (guix cpu), which also
provides you the flags that you need.
Cheers
0001-gnu-Add-j.patch
Description: Text Data
- [bug#48463] gnu: Add j., elaexuotee, 2022/01/12
- [bug#48463] gnu: Add j., Maxime Devos, 2022/01/12
- [bug#48463] gnu: Add j., Maxime Devos, 2022/01/12
- [bug#48463] gnu: Add j., elaexuotee, 2022/01/12
- [bug#48463] gnu: Add j., Liliana Marie Prikler, 2022/01/12
- [bug#48463] gnu: Add j., elaexuotee, 2022/01/13
- [bug#48463] gnu: Add j.,
Liliana Marie Prikler <=
- [bug#48463] gnu: Add j., elaexuotee, 2022/01/15
- [bug#48463] gnu: Add j., Liliana Marie Prikler, 2022/01/15
- [bug#48463] gnu: Add j., elaexuotee, 2022/01/16
- [bug#48463] gnu: Add j., Liliana Marie Prikler, 2022/01/16
- [bug#48463] gnu: Add j., elaexuotee, 2022/01/16
- [bug#48463] gnu: Add j., Liliana Marie Prikler, 2022/01/16
- [bug#48463] gnu: Add j., elaexuotee, 2022/01/16
- [bug#48463] gnu: Add j., Liliana Marie Prikler, 2022/01/17
- [bug#48463] gnu: Add j., elaexuotee, 2022/01/17
- [bug#48463] gnu: Add j., Liliana Marie Prikler, 2022/01/18