[bug#53402] Rebase it for the new python packages

guix-patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#53402] Rebase it for the new python packages

From:	Vivien
Subject:	[bug#53402] Rebase it for the new python packages
Date:	Sun, 06 Feb 2022 15:49:44 +0100
User-agent:	Evolution 3.42.1

Hello, thank you for your review!

Le jeudi 03 février 2022 à 20:49 +0000, Vinicius Monego a écrit :
> To avoid future merge conflicts, please move the packages somewhere
> in
> the middle of the files instead of the bottom.

OK.

> As a rule of thumb for Python packages with tests in Pytest, the
> check
> phase is overriden and Pytest is called manually. When the tests are
> in
> a subfolder inside the module, add a --pyargs <package> parameter to
> the pytest command, see e.g. the python-cartopy package. I could run
> the python-nibabel tests with this change without having to delete
> anything.

OK.

> If the tests still can't run because of missing data, it's fine to
> source from the upstream repository instead of PyPI, or skip the few
> tests that need them or at all if the repository doesn't ship a
> setup.py. If tests are to be disabled, they should also have a
> comment
> with the reason.

For MNE, the test data set is a separate repository without a license,
so I disabled the tests.

> The 'test-less' packages shouldn't be needed AFAICS. Tests should run
> by overriding the check phase as stated above (untested).

The test-less packages are part of a dependency cycle; decopatch
requires them for the tests to run, and they require decopatch or each
other too. If I disable all tests (pytest-* and decopatch) it would
work, but I’m not sure I should do that.

> I also have a few comments about the patches in general:
> 
> > +    (source (origin
> > +              (method url-fetch)
> > +              (uri (pypi-uri "imageio-ffmpeg" version))
> > +              (sha256
> > +               (base32
> > +               
> > "0ff14079izsyxwf6ki68k9a7w5krjlal7lwqvzg2bbddl92l5spj"))))
> 
> Could you style it as
> 
>     (source
>      (origin
>        (method url-fetch)
>        (uri (pypi-uri "imageio-ffmpeg" version))
>        (sha256
>         (base32
> "0ff14079izsyxwf6ki68k9a7w5krjlal7lwqvzg2bbddl92l5spj"))))
> 
> and the other packages too?

OK.

> Gexps should only be used when ungexp (#$) is used. On many patches
> (e.g. python-nitime) ungexp is not being used.

OK, I upgraded python-pooch again and it needs gexps too now.

> 
> When using gexp, it's better to style the arguments as:
> 
> +    (arguments
> +     (list
> +       #:phases
> +       #~(modify-phases %standard-phases
> 
> to save columns (some of the packages exceeded the 78 columns limit),
> instead of
> 
> > +    (arguments
> > +     (list #:phases
> > +           #~(modify-phases %standard-phases
> > 

OK.

> .
> 
> Some of the descriptions are not full sentences (e.g. in python-
> pytest-
> harvest-minimal). Please check that descriptions are full sentences.

I’m not sure I understand. I reworked some descriptions, but didn’t
find non-full sentences. Could you explain what you mean?

> When sending an updated series, use patch versions with --reroll-
> count=4 or -v4.

I didn’t know that option.

> Could you send a v4 with the requested changes?

Sure!

Best regards,

Vivien