[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#53818] [PATCH v2 5/7] import: Add 'repology' updater.
From: |
Maxime Devos |
Subject: |
[bug#53818] [PATCH v2 5/7] import: Add 'repology' updater. |
Date: |
Mon, 07 Feb 2022 10:50:10 +0100 |
User-agent: |
Evolution 3.38.3-1 |
Xinglu Chen schreef op ma 07-02-2022 om 10:07 [+0100]:
> +(define (latest-release package)
> + (mock ((guix import json) json-fetch
> + (lambda* (url #:key cached?)
> + (json-string->scm %test-json)))
> + (repology-latest-release package)))
It would be nice to verify the URL.
FWIW, there's a 'with-http-server' macro.
although it might need to be extended a little, see e.g.
<https://issues.guix.gnu.org/53389>.
Also, you are using 'memoize' in repology-fetch-info,
so the memoisation cache needs to be invalidated
(see e.g. tests/minetest.scm), or not, depending
on how 'repology-fetch-info' is used and tests are written.
Greetings,
Maxime.
signature.asc
Description: This is a digitally signed message part
- [bug#53818] [PATCH 2/3] import: Add 'repology' updater., (continued)
[bug#53818] [PATCH v2 3/7] http-client: 'http-fetch/cached' accepts a string or a <uri>., Xinglu Chen, 2022/02/07
[bug#53818] [PATCH v2 2/7] http-client: Make 'http-fetch/cached' take '#:headers' argument., Xinglu Chen, 2022/02/07
[bug#53818] [PATCH v2 6/7] gnu: xorg-server-xwayland: Set 'repology-name' property., Xinglu Chen, 2022/02/07
[bug#53818] [PATCH v2 7/7] gnu: xorg-server-xwayland: Prepare for cross-compilation., Xinglu Chen, 2022/02/07
[bug#53818] [PATCH v2 4/7] import: json: Make 'json-fetch' take '#:cached?' argument., Xinglu Chen, 2022/02/07
[bug#53818] [PATCH v3 0/7] Add Repology updater, Xinglu Chen, 2022/02/09