[bug#53851] [PATCH] gnu: Add emacs-latex-preview-pane.

[Nicolas Goaziou]

Hello,

Jai Vetrivelan <jaivetrivelan@gmail.com> writes:

> Subject: [PATCH] gnu: Add emacs-latex-preview-pane.

Thank you.
>
> * gnu/packages/emacs-xyz.scm (emacs-latex-preview-pane): new variable.

Nitpick: capitalize "New".

> +       (arguments
> +        ;; The welcome and error message templates are in .txt format.
> +        '(#:include '("\\.el$" "\\.txt$")))

You can switch to G-expressions:

    (arguments
     (list
      #:include #~(list "\\.el$" "\\.txt$")))

This is a bit more verbose, tho.

> +       (home-page "https://www.emacswiki.org/emacs/LaTeXPreviewPane";)

Why is the home-page pointing to EmacsWiki? Shouldn't it point to the
repository instead?

> +       (synopsis "Makes LaTeX editing less painful by providing a updatable
> +preview pane")

I suggest something shorter and more neutral:

    "Preview pane to ease LaTeX editing in Emacs"

> +       (description "@code{latex-preview-pane} is a minor mode for Emacs that
> +enables you to preview your LaTeX files directly in Emacs. It supports PDF
> +previews, your choice of pdflatex or xelatex, and it highlights errors in 
> your
> +LaTeX buffer.")

Nitpick: I would remove all "your" references…

  "@code{latex-preview-pane} is a minor mode for previewing LaTeX files
  directly in Emacs. It supports PDF previews, with either
  @command{pdflatex} or @command{xelatex}, and highlights errors in the
  LaTeX buffer.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou