[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#53930] [PATCH] gnu: Add emacs-nyan-mode.
From: |
Nicolas Goaziou |
Subject: |
[bug#53930] [PATCH] gnu: Add emacs-nyan-mode. |
Date: |
Thu, 10 Feb 2022 23:58:09 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hello,
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> * gnu/packages/emacs-xyz.scm (emacs-nyan-mode): New variable.
And I thought Guix was a serious distribution… ;)
> +(define-public emacs-nyan-mode
> + (package
> + (name "emacs-nyan-mode")
> + (version "1.1.3")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://stable.melpa.org/packages/nyan-mode-"
> + version
> + ".tar"))
Using anything MELPA is generally frowned upon. What are the reasons for
not using upstream releases instead?
> + (sha256
> + (base32 "1hd3g1lnwsg7z3g9qvshlmlirgzyja4hjxxgdfpkaakafm87n58c"))))
> + (build-system emacs-build-system)
> + (arguments (list #:include #~(cons* "img/" "mus/" %default-include)))
> + (home-page "https://github.com/TeMPOraL/nyan-mode/")
> + (synopsis "Nyan Cat as position indicator")
Maybe: Nyan Cat as position indicator in a buffer
> + (description
> + "Nyan Mode is an analog indicator of your position in the buffer.
I know the project name is "nyan mode" but still:
Nitpick: Nyan mode is…
Otherwise LGTM.
Regards,
--
Nicolas Goaziou