[bug#53964] [PATCH 3/4] gnu: ghc@4: Build without referring to packages in commencement.scm.

[Maxime Devos]

Ludovic Courtès schreef op za 12-02-2022 om 22:45 [+0100]:
> -       (patches (list (search-patch "ghc-4.patch")))))
> +       (patches (search-patches "ghc-4.patch"))))

Looks like an unrelated change to me.  From (guix)Submitting Patches:

  13. Verify that your patch contains only one set of related changes.
     Bundling unrelated changes together makes reviewing harder and
     slower.

     Examples of unrelated changes include the addition of several
     packages, or a package update along with fixes to that package.

Perhaps this is acceptable though for the same reasons removing
trailing #t from phases is acceptable ...

Greetings,
Maxime.

signature.asc
Description: This is a digitally signed message part