[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#53607: [PATCH] git-authenticate: Test introductory commit signature
From: |
Ludovic Courtès |
Subject: |
bug#53607: [PATCH] git-authenticate: Test introductory commit signature verification. |
Date: |
Mon, 14 Feb 2022 11:30:07 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Ludovic Courtès <ludo@gnu.org> skribis:
> These tests mimic similar tests already in 'tests/channels.scm', but
> without using the higher-level 'authenticate-channel'.
>
> * tests/git-authenticate.scm ("introductory commit, valid signature")
> ("introductory commit, missing signature")
> ("introductory commit, wrong signature"): New tests.
> ---
> tests/git-authenticate.scm | 106 ++++++++++++++++++++++++++++++++++++-
> 1 file changed, 105 insertions(+), 1 deletion(-)
>
> Hello!
>
> (Cc: Maxime + Attila since you’ve already looked into this code.)
>
> This patch adds tests to ensure that an invalidate introductory commit
> signature and lack of a signature on the introductory commit both lead
> to an error.
>
> These tests do not uncover any problem. In fact, this behavior was
> already tested in ‘tests/channels.scm’, but using the higher-level
> ‘authenticate-channel’ procedure.
>
> They were prompted by Attila’s comments in <https://issues.guix.gnu.org/50814>
> and by investigations that led to the bug fix I’m about to send (separately).
I went ahead and pushed it as 36cb04df96623ffe8f1074172a4ed9e51bcf6e3a.
Ludo’.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#53607: [PATCH] git-authenticate: Test introductory commit signature verification.,
Ludovic Courtès <=