[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#54180] [PATCH 00/12] Home: Clarify and better test symlink-manager.
From: |
Ludovic Courtès |
Subject: |
[bug#54180] [PATCH 00/12] Home: Clarify and better test symlink-manager.scm |
Date: |
Sun, 27 Feb 2022 14:40:06 +0100 |
Hello Guix!
This patch set aims to increase test coverage for ‘guix home reconfigure’,
to make symlink-manager.scm IMO easier to follow, and to have it more
closely follow the project’s conventions.
Functionality is unchanged.
Thoughts?
Thanks,
Ludo’.
Ludovic Courtès (12):
home: symlink-manager: Clarify module imports.
home: symlink-manager: Move helper procedures as top-level defines.
home: symlink-manager: Use 'for-each' when used for effects.
home: symlink-manager: Use 'file-is-directory?'.
home: symlink-manager: Remove 'empty-directory?' and avoid TOCTTOU
race.
home: symlink-manager: Avoid extra 'lstat' call.
tests: Make sure 'guix home reconfigure' backs up files.
tests: Simplify use of 'local-file' in 'tests/guix-home.sh'.
tests: Check 'guix home reconfigure' for a second generation.
home: symlink-manager: 'cleanup-symlinks' uses 'file-system-fold'.
home: symlink-manager: 'create-symlinks' uses 'file-system-fold'.
home: symlink-manager: Rename "path" to "file" where appropriate.
gnu/home/services/symlink-manager.scm | 355 ++++++++++++--------------
tests/guix-home.sh | 44 +++-
2 files changed, 198 insertions(+), 201 deletions(-)
base-commit: 33ce3f1c866231a3015411fdce18a3e72649e2f6
--
2.34.0
- [bug#54180] [PATCH 00/12] Home: Clarify and better test symlink-manager.scm,
Ludovic Courtès <=
- [bug#54180] [PATCH 01/12] home: symlink-manager: Clarify module imports., Ludovic Courtès, 2022/02/27
- [bug#54180] [PATCH 03/12] home: symlink-manager: Use 'for-each' when used for effects., Ludovic Courtès, 2022/02/27
- [bug#54180] [PATCH 02/12] home: symlink-manager: Move helper procedures as top-level defines., Ludovic Courtès, 2022/02/27
- [bug#54180] [PATCH 06/12] home: symlink-manager: Avoid extra 'lstat' call., Ludovic Courtès, 2022/02/27
- [bug#54180] [PATCH 12/12] home: symlink-manager: Rename "path" to "file" where appropriate., Ludovic Courtès, 2022/02/27
- [bug#54180] [PATCH 07/12] tests: Make sure 'guix home reconfigure' backs up files., Ludovic Courtès, 2022/02/27
- [bug#54180] [PATCH 11/12] home: symlink-manager: 'create-symlinks' uses 'file-system-fold'., Ludovic Courtès, 2022/02/27