guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#54260] [PATCH 2/3] gnu: ucsim: Don't explicitly return #t from phas


From: Simon South
Subject: [bug#54260] [PATCH 2/3] gnu: ucsim: Don't explicitly return #t from phases.
Date: Sat, 05 Mar 2022 11:39:38 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

Maxime Devos <maximedevos@telenet.be> writes:
> Additionally, you could make the #:configure-flags a G-exp and
> eliminate input labels (or, in this case, output labels)

This occurred to me, but is it not better in this case to rely on the
"output" parameter passed into the procedure?  Using "#$output" in this
context feels like a violation of the Law of Demeter, like using a
global variable where a local one would be appropriate.

I'll drop the first patch though; I'd missed seeing the definition of
"gnu-cross-build".

-- 
Simon South
simon@simonsouth.net





reply via email to

[Prev in Thread] Current Thread [Next in Thread]