[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#54328] [PATCH] Add emacs-org-remark-1.0.3
From: |
Nicolas Goaziou |
Subject: |
[bug#54328] [PATCH] Add emacs-org-remark-1.0.3 |
Date: |
Thu, 10 Mar 2022 18:28:46 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hello,
Алексей Дроздов <drozdov@portalenergy.tech> writes:
> Subject: [PATCH] Add emacs-org-remark-1.0.3
Thanks. Some comments follow.
First, our commit messages are somewhat normalized, so this should be:
gnu: Add emacs-org-remark.
* gnu/packages/emacs-xyz.scm (emacs-org-remark): New variable.
Note the message doesn't contain the version, but specify the exact name
of the variable being added.
> +(define-public emacs-org-remark
> + (let ((commit "b2e632cf66c748951910bc493915759ee8a9c22c")
> + (revision "0"))
You don't need to specify a revision since this pair matches an
un-tagged version bump.
> + (package
> + (name "emacs-org-remark")
> + (version (git-version "1.0.3" revision commit))
Per above, this should be plain "1.0.3".
> + (description "@code{emacs-org-remark} lets you highlight and annotate
> any text file with using Org mode.")
I think the name is Org-remark, not emacs-org-remark, which is the name
of the Guix variable.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou