guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#53019] [PATCH 1/3] gnu: Add python-codeclimate-test-reporter.


From: paul
Subject: [bug#53019] [PATCH 1/3] gnu: Add python-codeclimate-test-reporter.
Date: Mon, 14 Mar 2022 23:27:08 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0

Dear Maxime,

On 3/6/22 11:28, Maxime Devos wrote:
Giacomo Leidi via Guix-patches via schreef op zo 06-03-2022 om 00:14
[+0100]:
+  #:use-module (gnu packages version-control)
This creates a cycle between (gnu packages version-control) and
(gnu packages python-check).  To avoid cycles, could

   (a) python-codeclimate-test-reported be moved into a new module

or

   (b) the importing be delayed with (module-ref ...), like in
       (guix build-system gnu)?

By reducing cycles, "guix COMMAND some-package" needs to load less
modules and hence less memory.  There are also some other potential
benefits, e.g. see ‘Faster "guix pull" by incremental compilation and
non-circular modules?’ on guix-devel.

I wasn't aware of this, thank you. I fixed this by moving python-codeclimate-test-reported to (gnu packages python-xyz).

Greetings,

Giacomo







reply via email to

[Prev in Thread] Current Thread [Next in Thread]