guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#53523] [PATCH v3 2/2] gnu: neovim: Update to 0.6.1.


From: Zongyuan Li
Subject: [bug#53523] [PATCH v3 2/2] gnu: neovim: Update to 0.6.1.
Date: Wed, 16 Mar 2022 11:07:46 +0800
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0

Hi Luis,

I tried to apply `[PATCH v3 2/2] gnu: neovim: Update to 0.6.1.` to the current main branch of Guix, but failed.

It seems like we import 'libiconv' which is not used as dependency in previous neovim, from these code:

> @@ -717,11 +725,18 @@ (define-public neovim
>         ("unibilium" ,unibilium)
>         ("jemalloc" ,jemalloc)
>         ("libiconv" ,libiconv)
> -       ("lua" ,lua-5.1)
> +      ("lua" ,(if (member (or (if (%current-target-system)
> +                                   (gnu-triplet->nix-system (%current-target-system))
> +                                   #f)
> +                               (%current-system))
> +                           (package-supported-systems luajit))
> +                   luajit
> +                   lua-5.1))
>         ("lua-luv" ,lua5.1-luv)
>         ("lua-lpeg" ,lua5.1-lpeg)
>         ("lua-bitop" ,lua5.1-bitop)
> -       ("lua-libmpack" ,lua5.1-libmpack)))
> +      ("lua-libmpack" ,lua5.1-libmpack)
> +      ("tree-sitter" ,tree-sitter)))

Did you write this patch on any commit which is not included in the Guix main branch?

Maybe we should rebase this patch set on main branch.

Li





reply via email to

[Prev in Thread] Current Thread [Next in Thread]