guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#54201: [PATCH] Add wego


From: Nicolas Goaziou
Subject: bug#54201: [PATCH] Add wego
Date: Sat, 19 Mar 2022 00:59:09 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

Hello,

Ludovic Courtès <ludo@gnu.org> writes:

> Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:

>> +++ b/gnu/packages/weather.scm
>> @@ -0,0 +1,34 @@
>> +(define-module (gnu packages weather)
>
> Please add a license header.

Done.

>> +    (description "@strong{wego} is a weather client for the terminal.")
>
> Could you expound a little bit, mentioning key features, etc.?
>
> You can prolly remove @strong.

Done.

>> +    (license isc)))
>
> Perhaps #:prefix license: ?

I thought we needed to use the prefix only when there was a conflict in
the module.

Anyhow, done.

> Otherwise LGTM, thanks!

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou





reply via email to

[Prev in Thread] Current Thread [Next in Thread]