[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#54474] [PATCH 1/6] gnu: Add emacs-logos.
From: |
Nicolas Goaziou |
Subject: |
[bug#54474] [PATCH 1/6] gnu: Add emacs-logos. |
Date: |
Sun, 20 Mar 2022 14:30:28 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hello,
Jai Vetrivelan <jaivetrivelan@gmail.com> writes:
> Subject: [PATCH 1/6] gnu: Add emacs-logos.
>
> * gnu/packages/emacs-xyz.scm (emacs-logos): New variable.
Thanks. Some comments follow.
> (source (origin
> (method git-fetch)
> (uri (git-reference
> (url "https://gitlab.com/protesilaos/logos.git/")
You can drop the ".git" suffix, as mentioned by "guix lint".
> + (arguments
> + `(#:phases
You should use G-expressions here, if only to avoid writing
(assoc-ref outputs "out")
which is too low level.
So:
(arguments
(list
#:phases
#~(modifiy phases ...)))
> + (modify-phases %standard-phases
> + (add-after 'install 'makeinfo
> + (lambda* (#:key outputs #:allow-other-keys)
Here, this would become
(lambda _
...)
> + (invoke "emacs"
> + "--batch"
> + "--eval=(require 'ox-texinfo)"
> + "--eval=(find-file \"README.org\")"
> + "--eval=(org-texinfo-export-to-info)")
> + (install-file "logos.info"
> + (string-append (assoc-ref outputs "out")
> + "/share/info")))))))
And here:
(install-file "logos.info" (string-append #$output "/share/info"))
The same goes for other packages.
Could you send updated patches?
Regards,
--
Nicolas Goaziou
- [bug#54474] [PATCH 0/6] gnu: emacs-xyz: Add info manuals of packages, Jai Vetrivelan, 2022/03/20
- [bug#54474] [PATCH 2/6] gnu: Add emacs-pulsar., Jai Vetrivelan, 2022/03/20
- [bug#54474] [PATCH 3/6] gnu: Add emacs-lin., Jai Vetrivelan, 2022/03/20
- [bug#54474] [PATCH 4/6] gnu: Add emacs-tmr., Jai Vetrivelan, 2022/03/20
- [bug#54474] [PATCH 6/6] gnu: emacs-mct: Add Info manual., Jai Vetrivelan, 2022/03/20
- [bug#54474] [PATCH 5/6] gnu: emacs-modus-themes: Add Info manual., Jai Vetrivelan, 2022/03/20
- [bug#54474] [PATCH 1/6] gnu: Add emacs-pulsar., Jai Vetrivelan, 2022/03/20