[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#54723] [PATCH] Check URI when verifying narinfo validity.
From: |
Ludovic Courtès |
Subject: |
[bug#54723] [PATCH] Check URI when verifying narinfo validity. |
Date: |
Tue, 05 Apr 2022 19:08:12 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi,
Guillaume Le Vaillant <glv@posteo.net> skribis:
> When trying to upgrade a machine using a substitute server on the same
> LAN, I get this crash a lot:
>
> # guix system reconfigure --substitute-urls="http://192.168.0.22:8080
> https://ci.guix.gnu.org" /etc/guix/config.scm
> substitute: mise à jour des substituts depuis « http://192.168.0.22:8080 »...
> 100.0 %
[...]
> It looks like the 'narinfo-uri' field is an empty list instead of a list
> of URIs. Is that supposed to be possible?
I don’t think so. Could you grab a narinfo and share it?
wget -qO - http://192.168.0.22:8080/HASH.narinfo
where HASH is the hash part of a store item.
What could happen though is a situation where ‘guix publish’ only offers
a compression method not supported by the client. In that case,
‘narinfo-best-uri’ throws a match-error because ‘choices’ is the empty
list. We should fix that.
> Does the the attached patch adding a check for the validity of
> this field in the 'valid-narinfo?' function make sense?
Maybe, but I’d like to make sure we understand the issue.
Thanks,
Ludo’.
- [bug#54723] [PATCH] Check URI when verifying narinfo validity., Guillaume Le Vaillant, 2022/04/05
- [bug#54723] [PATCH] Check URI when verifying narinfo validity.,
Ludovic Courtès <=
- [bug#54723] [PATCH] Check URI when verifying narinfo validity., Guillaume Le Vaillant, 2022/04/05
- [bug#54723] [PATCH] Check URI when verifying narinfo validity., Ludovic Courtès, 2022/04/09
- [bug#54723] [PATCH] Check URI when verifying narinfo validity., Guillaume Le Vaillant, 2022/04/09
- [bug#54723] [PATCH] Check URI when verifying narinfo validity., Guillaume Le Vaillant, 2022/04/11
- [bug#54723] [PATCH] Check URI when verifying narinfo validity., Ludovic Courtès, 2022/04/12
- [bug#54723] [PATCH] Check URI when verifying narinfo validity., Guillaume Le Vaillant, 2022/04/12
- [bug#54723] [PATCH] Check URI when verifying narinfo validity., Guillaume Le Vaillant, 2022/04/14
- [bug#54723] [PATCH] Check URI when verifying narinfo validity., Ludovic Courtès, 2022/04/18
- [bug#54723] [PATCH] Check URI when verifying narinfo validity., Guillaume Le Vaillant, 2022/04/20
- [bug#54723] [PATCH] Check URI when verifying narinfo validity., Ludovic Courtès, 2022/04/29