[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#54796] [PATCH v3 00/22] Add importer for hex.pm and rebar3 build-sy
From: |
Ludovic Courtès |
Subject: |
[bug#54796] [PATCH v3 00/22] Add importer for hex.pm and rebar3 build-system for Erlang |
Date: |
Fri, 29 Apr 2022 15:06:16 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi,
Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:
> * guix/build-system/rebar3.scm, guix/build/rebar3-build-system.scm: New files.
> * Makefile.am (MODULES): Add them.
Please mention the guix.texi changes here.
> +@defvr {Scheme Variable} rebar3-build-system
> +This variable is exported by @code{(guix build-system rebar3)}. It
> +implements a build procedure around @code{rebar3}.
Please provide a bit more context, like: “[…] around
@uref{http://example.org,rebar3}, a build system for programs written in
the Erlang language.”
> +source. If this file exists, it will be unpacked, too. This eases
> +handling of package hosted by @i{hex.pm}.
Rather: “hosted at @uref{https://hex.pm/}, the Erlang package
repository.”
> + (lambda (*)
> + (for-each
> + (lambda (dirname)
> + (let ((src-dir (string-append lib-dir "/" * "/" dirname))
> + (dst-dir (string-append pkg-dir "/" dirname)))
> + (when (file-exists? src-dir)
> + (copy-recursively src-dir dst-dir #:follow-symlinks? #t))
> + (false-if-exception
> + (delete-file (string-append dst-dir "/.gitignore")))))
> + '("ebin" "include" "priv")))
“ebin” and “priv” are non-standard directory names. It would be ideal
to avoid them, unless this is a hard requirement for Erlang/rebar3?
Otherwise LGTM!
Thanks,
Ludo’.
- [bug#54796] [PATCH v3 01/22] import: Add hex.pm importer., (continued)
- [bug#54796] [PATCH v3 02/22] gnu: Add erlang-cf., Hartmut Goebel, 2022/04/08
- [bug#54796] [PATCH v3 08/22] gnu: Add erlang-eunit-formatters., Hartmut Goebel, 2022/04/08
- [bug#54796] [PATCH v3 11/22] gnu: Add erlang-hex-core., Hartmut Goebel, 2022/04/08
- [bug#54796] [PATCH v3 17/22] gnu: Add erlang-covertool., Hartmut Goebel, 2022/04/08
- [bug#54796] [PATCH v3 20/22] gnu: Add rebar3-git-vsn., Hartmut Goebel, 2022/04/08
- [bug#54796] [PATCH v4 00/22] Add importer for hex.pm and rebar3 build-system for Erlang, Hartmut Goebel, 2022/04/10
- [bug#54796] [PATCH v4 02/22] build-system: Add 'rebar3-build-system'., Hartmut Goebel, 2022/04/10
- [bug#54796] [PATCH v3 00/22] Add importer for hex.pm and rebar3 build-system for Erlang,
Ludovic Courtès <=
- [bug#54796] [PATCH v4 01/22] import: Add hex.pm importer., Hartmut Goebel, 2022/04/10
- [bug#54796] [PATCH v4 03/22] gnu: Add erlang-cf., Hartmut Goebel, 2022/04/10
- [bug#54796] [PATCH v4 04/22] gnu: Add erlang-certifi., Hartmut Goebel, 2022/04/10
- [bug#54796] [PATCH v4 05/22] gnu: Add erlang-erlware-commons., Hartmut Goebel, 2022/04/10
- [bug#54796] [PATCH v4 06/22] gnu: Add erlang-cth-readable., Hartmut Goebel, 2022/04/10
- [bug#54796] [PATCH v4 08/22] gnu: Add erlang-getopt., Hartmut Goebel, 2022/04/10
- [bug#54796] [PATCH v4 07/22] gnu: Add erlang-bbmustache., Hartmut Goebel, 2022/04/10
- [bug#54796] [PATCH v4 11/22] gnu: Add erlang-parse-trans., Hartmut Goebel, 2022/04/10
- [bug#54796] [PATCH v4 10/22] gnu: Add erlang-providers., Hartmut Goebel, 2022/04/10