[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'
From: |
zimoun |
Subject: |
[bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'. |
Date: |
Fri, 27 May 2022 15:23:31 +0200 |
Hi Maxime,
On Fri, 27 May 2022 at 15:04, Maxime Devos <maximedevos@telenet.be> wrote:
> scheme@(guile-user)> (call-with-input-file "a" read)
> ice-9/boot-9.scm:1669:16: In procedure raise-exception:
> In procedure scm_lreadr: a:2:1: end of file in string constant
This is an ad-hoc example and not a real test case.
--8<---------------cut here---------------start------------->8---
$ echo "foo" > ~/.cache/guix/inferiors/last-expiry-cleanup
$ cat ~/.cache/guix/inferiors/last-expiry-cleanup
foo
$ ./pre-inst-env guix time-machine --commit=9d795fb -- help
Usage: guix OPTION | COMMAND ARGS...
Run COMMAND with ARGS, if given.
--8<---------------cut here---------------end--------------->8---
As previously mentioned, the patch fixes:
- empty file
- non-integer
I am not able to imagine an incomplete file worse than \\x00.
> The difference is that ^R is interpreted as a symbol, whereas "foo
> cannot be interpreted as anything at all by 'read'.
I do not understand what you mean and I think you are overengineering.
If you are able to produce a corrupted file which breaks "guix
time-machine", then we can examine. Else let move on. :-)
Cheers,
simon
- [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'., zimoun, 2022/05/27
- [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'., Maxime Devos, 2022/05/27
- [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'., zimoun, 2022/05/27
- [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'., Maxime Devos, 2022/05/27
- [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'., zimoun, 2022/05/27
- [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'., Maxime Devos, 2022/05/27
- [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'., zimoun, 2022/05/27
- [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'., Maxime Devos, 2022/05/27
- [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'.,
zimoun <=
- [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'., zimoun, 2022/05/27
- [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'., Maxime Devos, 2022/05/27
- [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'., zimoun, 2022/05/27
- [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'., Maxime Devos, 2022/05/27
- [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'., Maxime Devos, 2022/05/27
- [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'., zimoun, 2022/05/27
- [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'., Maxime Devos, 2022/05/27
[bug#55673] [PATCH v2] cache: Catch valid integer for 'last-expiry-cleanup'., zimoun, 2022/05/27