[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#56898] [PATCH 00/13] Put the pretty printer to good use
From: |
Ludovic Courtès |
Subject: |
[bug#56898] [PATCH 00/13] Put the pretty printer to good use |
Date: |
Tue, 2 Aug 2022 23:42:36 +0200 |
Hello Guix!
I shaved a yak! This patch series promotes the pretty reader/printer
of ‘guix style’ to its own module, improves it so it can deal with
vertical space, adds a ‘-f’ option to ‘guix style’ to reformat
whole files, changes the installer to use this pretty-printer, and
changes the installer so it emits comments and vertical space in
the generated configuration.
You can use ‘guix style -f’ on any Scheme file. The pretty-printer
does a decent job, though there are still cases where it’s not as
good as my little hands at formatting things nicely. For newcomers,
it should be very helpful.
Comments? Vertical space? Page breaks?
Ludo’.
Ludovic Courtès (13):
style: Move reader and printer to (guix read-print).
read-print: Add System and Home special forms.
read-print: Expose comment constructor.
read-print: Introduce <blank> parent class of <comment>.
style: Adjust test to not emit blank lines.
read-print: Read and render vertical space.
read-print: Recognize page breaks.
read-print: Add code to read and write sequences of
expressions/blanks.
read-print: 'canonicalize-comment' leaves top-level comments
unchanged.
style: Add '--whole-file' option.
read-print: Support printing multi-line comments.
installer: Render the final configuration with (guix read-print).
installer: Add comments and vertical space to the generated config.
Makefile.am | 3 +
doc/guix.texi | 28 +-
gnu/installer.scm | 3 +-
gnu/installer/parted.scm | 10 +-
gnu/installer/services.scm | 39 ++-
gnu/installer/steps.scm | 32 +-
gnu/installer/user.scm | 7 +-
guix/read-print.scm | 678 +++++++++++++++++++++++++++++++++++++
guix/scripts/import.scm | 4 +-
guix/scripts/style.scm | 527 +++-------------------------
tests/guix-style.sh | 80 +++++
tests/read-print.scm | 358 ++++++++++++++++++++
tests/style.scm | 185 +---------
13 files changed, 1270 insertions(+), 684 deletions(-)
create mode 100644 guix/read-print.scm
create mode 100644 tests/guix-style.sh
create mode 100644 tests/read-print.scm
base-commit: d7e7494bc4d69de9db49488ee812e572c3250211
--
2.37.1
- [bug#56898] [PATCH 00/13] Put the pretty printer to good use,
Ludovic Courtès <=
- [bug#56898] [PATCH 01/13] style: Move reader and printer to (guix read-print)., Ludovic Courtès, 2022/08/02
- [bug#56898] [PATCH 02/13] read-print: Add System and Home special forms., Ludovic Courtès, 2022/08/02
- [bug#56898] [PATCH 03/13] read-print: Expose comment constructor., Ludovic Courtès, 2022/08/02
- [bug#56898] [PATCH 04/13] read-print: Introduce <blank> parent class of <comment>., Ludovic Courtès, 2022/08/02
- [bug#56898] [PATCH 07/13] read-print: Recognize page breaks., Ludovic Courtès, 2022/08/02
- [bug#56898] [PATCH 05/13] style: Adjust test to not emit blank lines., Ludovic Courtès, 2022/08/02
- [bug#56898] [PATCH 09/13] read-print: 'canonicalize-comment' leaves top-level comments unchanged., Ludovic Courtès, 2022/08/02
- [bug#56898] [PATCH 13/13] installer: Add comments and vertical space to the generated config., Ludovic Courtès, 2022/08/02
- [bug#56898] [PATCH 11/13] read-print: Support printing multi-line comments., Ludovic Courtès, 2022/08/02
- [bug#56898] [PATCH 08/13] read-print: Add code to read and write sequences of expressions/blanks., Ludovic Courtès, 2022/08/02