[bug#55682] [PATCH V2 1/3] gnu: Add lcrq.

[Maxime Devos]

On 31-07-2022 01:41, Vagrant Cascadian wrote:
> +                  (replace 'check
> +                    (lambda _
> +                      (invoke "make" "test"))))))

I expect "./pre-inst-env guix lint lcrq" to have a warning about 
respecting #:tests?. This is important for --without-tests and 
cross-compilation. Likewise for the other patches.

> +       #:make-flags (let ((target ,(%current-target-system)))
> +                      (list ,(string-append "CC="
> +                                            (cc-for-target))
> +                            (string-append "PREFIX="
> +                                           (assoc-ref %outputs "out"))))
'target' is unused and can be removed.

Greetings,
Maxime.

OpenPGP_0x49E3EE22191725EE.asc
Description: OpenPGP public key

OpenPGP_signature
Description: OpenPGP digital signature