guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#57056] [PATCH] Update python-lsp-server


From: Mathieu Othacehe
Subject: [bug#57056] [PATCH] Update python-lsp-server
Date: Fri, 12 Aug 2022 11:03:35 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)

Hello,

> -       (modify-phases %standard-phases
> -         (add-before 'check 'set-HOME
> -           (lambda _ (setenv "HOME" "/tmp")))

You need to document it in the commit message, this way:

[arguments]{set-HOME}: Remove this phase because...
{check}: Do not replace it as test_pyqt_completion is not longer
failing.

or something similar.
>      (propagated-inputs
>       (list python-autopep8
>             python-pydocstyle
>             python-flake8
> -           python-future
>             python-jedi
>             python-lsp-jsonrpc
>             python-pluggy
>             python-pycodestyle
>             python-pyflakes
>             python-rope
> +           python-setuptools
>             python-ujson
>             python-yapf))
>      (native-inputs
>       (list python-coverage
>             python-flaky
>             python-matplotlib
> -           python-mock
>             python-numpy
>             python-pandas
>             python-pylint
>             python-pytest
>             python-pytest-cov
> -           python-versioneer))
> +           python-whatthepatch))

Ditto, with something like

[propagated-inputs]: Remove python-future and add python-setuptools.
[native-inputs]: Remove python-mock, python-versioneer and add
python-whatthepatch.

Could you please send a v2?

Thanks,

Mathieu





reply via email to

[Prev in Thread] Current Thread [Next in Thread]