guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#57133] [PATCH] gnu: Add rizin.


From: 宋文武
Subject: [bug#57133] [PATCH] gnu: Add rizin.
Date: Mon, 15 Aug 2022 09:36:20 +0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)

Jean Pierre De Jesus DIAZ <me@jeandudey.tech> writes:

> Hello, 
>
>>+          (add-after 'unpack 'prepare-testbins
>>+            (lambda _
>>+              (copy-recursively
>>+               #$(origin
>>+                   (method git-fetch)
>>+                   (uri (git-reference
>>+                         (url "https://github.com/rizinorg/rizin-testbins";)
>>+                         (commit 
>>"7d0c31ac7711de9c4d37f5047200dc5a407ff713")))
>>+                   (sha256
>>+                    (base32
>>+                     
>>"00cmc7pws9m4hcm0bpdjm6n4agl5mqgczc4ccswfhywyzzvr7sqh")))
>>+               "test/bins")))
>
> Could this instead be replaced with a package? The repository also says that
> the binaries could be regenerated and it's worth a look looking into if it
> can be done so the built binaries can be removed (through snippets for 
> example)
> and re-compiled from sources, of course, those that can be re-generated should
> be left as is. If the binaries can't be regenerated feel free to ignore this
> comment :).

Well I find no way to regenerate those binaries, so I'd remove it and
skip integration tests as suggested by Maxime Devos.  Thanks for the
comment!





reply via email to

[Prev in Thread] Current Thread [Next in Thread]