[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#57257] [PATCH 00/31] Update LXQt to 1.1.0
From: |
宋文武 |
Subject: |
[bug#57257] [PATCH 00/31] Update LXQt to 1.1.0 |
Date: |
Mon, 22 Aug 2022 08:55:03 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Ricardo Wurmus <rekado@elephly.net> writes:
> Hi,
>
> overall this looks good to me. Thank you for working on it!
>
> There are just a few questions:
>
> - does it really work to use relative file names? Would it be possible
> to test this roughly in a system test?
Yes, the relative file names are for install, at runtime most things
works as designed with XDG_DATA_DIRS and XDG_CONFIG_DIRS.
A system test could verify items in lxqt-config, will look it later...
>
> - you’re removing a lot of patch-source phases. Why are these no longer
> needed?
Yeah, I find that use relative file names in LXQtConfigVars.cmake remove
the need of patching other cmake files.
>
> - you’re also removing patch-translations-dir phases. Do translations
> still work after applying these changes?
Yes, at runtime they are found under XDG_DATA_DIRS, by
lxqttranslator.cpp:
*searchPath << XdgDirs::dataDirs(QL1C('/') +
QL1S(LXQT_RELATIVE_SHARE_TRANSLATIONS_DIR));
> [...]
>
> Feel free to push this!
Okay, thanks for the review!
- [bug#57257] [PATCH 21/31] gnu: pcmanfm-qt: Update to 1.1.0., (continued)
- [bug#57257] [PATCH 21/31] gnu: pcmanfm-qt: Update to 1.1.0., iyzsong, 2022/08/16
- [bug#57257] [PATCH 23/31] gnu: lximage-qt: Update to 1.1.0., iyzsong, 2022/08/16
- [bug#57257] [PATCH 25/31] gnu: pavucontrol-qt: Update to 1.1.0., iyzsong, 2022/08/16
- [bug#57257] [PATCH 26/31] gnu: qps: Update 2.5.0., iyzsong, 2022/08/16
- [bug#57257] [PATCH 31/31] gnu: lxqt-connman-applet: Remove patch-translations-dir phase., iyzsong, 2022/08/16
- [bug#57257] [PATCH 30/31] gnu: lxqt-archiver: Update to 0.6.0., iyzsong, 2022/08/16
- [bug#57257] [PATCH 28/31] gnu: qterminal: Update to 1.1.0., iyzsong, 2022/08/16
- [bug#57257] [PATCH 29/31] gnu: screengrab: Update to 2.4.0., iyzsong, 2022/08/16
- [bug#57257] [PATCH 00/31] Update LXQt to 1.1.0, Ricardo Wurmus, 2022/08/21
- bug#57257: [PATCH 00/31] Update LXQt to 1.1.0, 宋文武, 2022/08/21