[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#57171] [PATCH] gnu: Add emacs-pdfgrep.
|
From: |
Ricardo Wurmus |
|
Subject: |
[bug#57171] [PATCH] gnu: Add emacs-pdfgrep. |
|
Date: |
Tue, 23 Aug 2022 12:07:30 +0200 |
|
User-agent: |
mu4e 1.8.7; emacs 28.1 |
Thanks for the patch.
I’d change the let* to let, because we don’t need previous bindings to
be available in later bindings.
It would also be nice to avoid propagating pdfgrep.
We could probably avoid propagation by patching
https://github.com/jeremy-compostella/pdfgrep/blob/master/pdfgrep.el#L59
and perhaps also line 81 (executable-find "pdfgrep").
In the synopsis I’d remove the `…' quotes, but that’s a nit-pick.
What do you think?
--
Ricardo