[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#57304] Fix mm-common reproduciblility issues
From: |
Ludovic Courtès |
Subject: |
[bug#57304] Fix mm-common reproduciblility issues |
Date: |
Tue, 30 Aug 2022 22:34:33 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Hi,
Vagrant Cascadian <vagrant@reproducible-builds.org> skribis:
> The userid used during the build is embedded in a shipped tarball in the
> mm-common package. Some abbreviated diffoscope output from guix
> challenge against builds from ci.guix.gnu.org and bordeax.guix.gnu.org:
Good catch.
> The attached patch fixes this by setting the user, group, uid and gid
> consistently.
>
> $ guix refresh --list-dependent mm-common
> Building the following 1138 packages would ensure 2236 dependent
> packages are rebuilt: ...
>
> Looks like it will have to wait for core-updates at least...
Yeah, let’s apply it on ‘core-updates’.
> From 4b359c9bbc918e6dcf1cab1141a9651d6d7bf271 Mon Sep 17 00:00:00 2001
> From: Vagrant Cascadian <vagrant@reproducible-builds.org>
> Date: Fri, 19 Aug 2022 19:32:08 -0700
> Subject: [PATCH] gnu: mm-common: Build reproducibly.
>
> * gnu/packages/patches/mm-common-consistent-user-and-group-in-tarball.patch:
> New file.
> * gnu/local.mk (dist_patch_DATA): Add patch.
> * gnu/packages/gnome.scm (mm-common)[source]: Add patch.
[...]
> + %D%/packages/patches/mm-common-consistent-user-and-group-in-tarball.patch \
I’d suggest a shorter name to appease ‘tar’, say
‘mm-common-reproducible-tarball.patch’.
Otherwise LGTM, thanks!
Ludo’.