[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#57688] [PATCH v4] gnu: Add wiggle.
From: |
Maxime Devos |
Subject: |
[bug#57688] [PATCH v4] gnu: Add wiggle. |
Date: |
Fri, 9 Sep 2022 14:35:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 |
On 09-09-2022 06:14, jgart wrote:
+ (arguments
+ (list #:make-flags
+ #~(list "-I. -O3"
+ (string-append "CC=" #$(cc-for-target))
+ "INSTALL=\"install\""
+ "STRIP=-s"
+ (string-append "BINDIR=" #$output "/bin")
+ (string-append "MANDIR=" #$output "/share/man")
+ (string-append "CC=" #$(cc-for-target))
+ (string-append "PREFIX=" #$output))
+ #:phases
+ '(modify-phases %standard-phases
Nitpick: using G-exp for #:make-flags but not #:phases is inconsistent,
though that's something a committer could adjust without any trouble.
+ (delete 'configure)
+ (replace 'check
+ (lambda* (#:key inputs ouputs tests? #:allow-other-keys)
+ (when tests?
+ (invoke "./dotest")))))))
That's what I had in mind, thanks. For completeness, ideally someone
would check the sources for malware, but otherwise LGTM.
Greetings,
Maxime.
OpenPGP_0x49E3EE22191725EE.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
- [bug#57688] [PATCH] gnu: Add wiggle., jgart, 2022/09/08
- [bug#57688] [PATCH v2] gnu: Add wiggle., jgart, 2022/09/08
- [bug#57688] [PATCH] gnu: Add wiggle., Maxime Devos, 2022/09/08
- [bug#57688] [PATCH v3] gnu: Add wiggle., jgart, 2022/09/08
- [bug#57688] [PATCH v4] gnu: Add wiggle., jgart, 2022/09/09
- [bug#57688] [PATCH v4] gnu: Add wiggle.,
Maxime Devos <=
- [bug#57688] [PATCH v5] gnu: Add wiggle., jgart, 2022/09/09
- [bug#57688] [PATCH v6] gnu: Add wiggle., jgart, 2022/09/09
- [bug#57688] [PATCH v7] gnu: Add wiggle., jgart, 2022/09/10