guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#57671] [PATCH] gnu: Add mpdevil.


From: Christopher Baines
Subject: [bug#57671] [PATCH] gnu: Add mpdevil.
Date: Sat, 10 Sep 2022 10:50:04 +0100
User-agent: mu4e 1.6.11; emacs 28.1

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> * gnu/packages/mpd.scm (mpdevil): New variable.
> ---
>  gnu/packages/mpd.scm | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)

There's one lint warning that can be fixed, but apart from that this
looks good to me.

> diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
> index 046471f32d..c7d9b4646c 100644
> --- a/gnu/packages/mpd.scm
> +++ b/gnu/packages/mpd.scm
> @@ -523,3 +523,38 @@ (define-public mcg
>  album-experience.")
>      (home-page "https://gitlab.com/coderkun/mcg";)
>      (license license:gpl3+)))
> +
> +(define-public mpdevil
> +  (package
> +    (name "mpdevil")
> +    (version "1.7.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/SoongNoonien/mpdevil";)
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32 
> "1va8fqlz8qb68gvacnzmp4asnipi11316n1cv2wb41sml9d7v00j"))))
> +    (build-system meson-build-system)
> +    (arguments
> +     (list
> +      #:glib-or-gtk? #t
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'glib-or-gtk-wrap 'python-and-gi-wrap
> +            (lambda* (#:key outputs #:allow-other-keys)
> +              (let ((prog (string-append (assoc-ref outputs "out")
> +                                         "/bin/mpdevil")))
> +                (wrap-program prog
> +                  `("GUIX_PYTHONPATH" = (,(getenv "GUIX_PYTHONPATH")))
> +                  `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH"))))))))))

The linter says:

  "bash-minimal" should be in 'inputs' when 'wrap-program' is used

> +    (inputs (list gtk+ python python-mpd2 python-pygobject))
> +    (native-inputs (list `(,glib "bin")))
> +    (home-page "https://github.com/SoongNoonien/mpdevil";)
> +    (synopsis "Music browser for the MPD")
> +    (description "mpdevil is a music browser for the Music Player Daemon 
> (MPD),
> +which is focused on playing local music without the need of managing 
> playlists.
> +Instead of maintaining a client side database of your music library,
> +mpdevil loads all tags and covers on demand.")
> +    (license license:gpl3+)))

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]